[RemoteRuntime] Add option to enable async mode when using `nuclio' runtime with http trigger #9141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/sdk
area/server
area/api
area/tests
area/system-tests
labels
royischoss
requested review from
a team,
TomerShor and
liranbg
as code owners
davesh0812
changed the title
theSaarco
requested changes
Dec 31, 2025
mlrun/runtimes/nuclio/function.py
Outdated
| "Async spec is only supported on Nuclio 1.15.3 and higher" | ||
| ) | ||
| if async_spec.enabled: | ||
| trigger._struct["mode"] = "async" if async_spec.enabled else "sync" |
Member
There was a problem hiding this comment.
You get here since async_spec.enabled, so there's no way this will be sync.
liranbg
reviewed
Dec 31, 2025
tests/system/runtimes/test_nuclio.py
Outdated
| ) | ||
| function.spec.function_handler = "main:async_handler" | ||
|
|
||
| function.with_http(async_spec=AsyncSpec(enabled=True, max_connections=900)) |
Contributor
Author
There was a problem hiding this comment.
100 provide latency of 10 seconds passed with 200 with 5.5 seconds
davesh0812
approved these changes
Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This includes adding a async configuration while using
RemoteRuntime.with_http.initialization of default http trigger in async mode if- disabled till NUC-704 is donespec.graph.engineis "async"🛠️ Changes Made
AsyncSpecdataclass and adding it as input param forwith_httpdefault http with async engine(disabled) or by usingfunction.with_http(AsyncMode(enabled=True)✅ Checklist
🧪 Testing
Adding system test
TestNuclioRuntime:test_async_http_mode🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes