Skip to content

Conversation

@alxtkr77
Copy link
Member

@alxtkr77 alxtkr77 commented Dec 25, 2025

Description

Remove all TDEngine TSDB support from MLRun codebase. TimescaleDB (PostgreSQL) remains as the primary TSDB backend alongside V3IO TSDB.


Changes Made

  • Delete mlrun/model_monitoring/db/tsdb/tdengine/ directory
  • Remove TDEngineConnector, TDEngineConnection, and related schemas
  • Remove DatastoreProfileTDEngine from datastore profiles
  • Remove TDEngineStoreyTarget from storey targets
  • Remove TSDBTarget.TDEngine and TDEngineSuperTables enums
  • Remove taos-ws-py==0.3.2 from all requirements files
  • Delete tests/model_monitoring/db/tsdb/tdengine/ test directory
  • Delete tests/model_monitoring/test_tdengine.py
  • Remove TDEngine from parametrized tests
  • Remove TestTDEngineProfile test class
  • Update model monitoring documentation to reference TimescaleDB
  • Update installation guides (kubernetes.md, aws-install.md)
  • Update ecosystem.md and tutorials

Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR

Testing

  • Ran make fmt - passed
  • Ran make lint - all checks passed
  • Verified no TDEngine/taos references remain in Python, YAML, or notebook files
  • Historical deprecation notices in change-log are expected and remain

References


Breaking Changes?

  • Yes (explain below)
  • No

TDEngine TSDB support is removed. Users who were using TDEngine for model monitoring must migrate to TimescaleDB (PostgreSQL) or V3IO TSDB

@alxtkr77 alxtkr77 requested review from a team, liranbg, rokatyy and yaelgen as code owners December 25, 2025 12:08
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@assaf758
Copy link
Member

assaf758 commented Jan 5, 2026

Fails in test:

FAILED tests/integration/sdk_api/hub/test_hub.py::TestHub::test_import_module_from_hub - mlrun.errors.MLRunBadRequestError: Failed to import module from temp/agent_deployer.py: cannot import name 'DatastoreProfileTDEngine' from 'mlrun.datastore.datastore_profile' (/mlrun/mlrun/datastore/datastore_profile.py)

Seems you need to update https://github.com/mlrun/functions/tree/master/modules/src/agent_deployer

@alxtkr77 alxtkr77 force-pushed the ML-11628-tdengine-removal branch from 0284765 to 86bba8d Compare January 8, 2026 09:39
Alex Toker added 2 commits January 8, 2026 11:33
Remove all TDEngine TSDB support from MLRun codebase. TDEngine was
deprecated in v1.10.0 following the 2-release deprecation cycle.
TimescaleDB (PostgreSQL) remains as the primary TSDB backend alongside
V3IO TSDB.

Core changes:
- Delete mlrun/model_monitoring/db/tsdb/tdengine/ directory (6 files)
- Remove TDEngineConnector, TDEngineConnection, and related schemas
- Remove DatastoreProfileTDEngine from datastore profiles
- Remove TDEngineStoreyTarget from storey targets
- Remove TSDBTarget.TDEngine and TDEngineSuperTables enums

Dependencies:
- Remove taos-ws-py==0.3.2 from all requirements files
- Update extras-requirements.txt and locked requirements

Tests:
- Delete tests/model_monitoring/db/tsdb/tdengine/ directory
- Delete tests/model_monitoring/test_tdengine.py
- Remove TDEngine from parametrized tests
- Remove TestTDEngineProfile test class

Reference: ML-11628
Update model monitoring docs to reference TimescaleDB instead of TDEngine.

Changes:
- Update model monitoring docs and installation guides
- Update kubernetes.md and aws-install.md
- Update ecosystem.md to list TimescaleDB instead of TDEngine
- Update tutorials and Jupyter notebooks

Reference: ML-11628
@alxtkr77 alxtkr77 force-pushed the ML-11628-tdengine-removal branch from 86bba8d to 7589d46 Compare January 8, 2026 12:06
@assaf758 assaf758 merged commit 160a94f into mlrun:development Jan 11, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants