Skip to content

Conversation

@weilerN
Copy link
Contributor

@weilerN weilerN commented Dec 22, 2025

📝 Description

This change adds backend validation for sidecar probe configurations during Nuclio function deployment.

Before deploying the function, the API now validates that each configured sidecar probe (readinessProbe, livenessProbe, startupProbe) defines exactly one Kubernetes health-check mechanism (httpGet, exec, tcpSocket, or grpc). Configurations that are missing a health check or define multiple checks are rejected with a clear 400 Bad Request error.

This validation is intentionally minimal and aligned with the Kubernetes V1Probe schema, ensuring obvious misconfigurations are caught early while avoiding deep field-level validation.


🛠️ Changes Made

  • Added backend validation for sidecar probes before deployment.

✅ Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR
  • I confirmed whether my changes are covered by system tests
    • If yes, I ran all relevant system tests and ensured they passed before submitting this PR
    • I updated existing system tests and/or added new ones if needed to cover my changes
  • If I introduced a deprecation:

🧪 Testing

  • Dev test: tested both negative and positive flows
  • Added unit tests

🔗 References


🚨 Breaking Changes?

  • Yes (explain below)
  • No

🔍️ Additional Notes

@weilerN weilerN requested review from TomerShor and rokatyy December 22, 2025 13:32
@weilerN weilerN marked this pull request as ready for review December 22, 2025 13:38
@weilerN weilerN requested a review from a team as a code owner December 22, 2025 13:38
@TomerShor TomerShor merged commit fd3c126 into mlrun:development Dec 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants