Skip to content

Conversation

@elbamit
Copy link
Contributor

@elbamit elbamit commented Dec 17, 2025

📝 Description

This PR mounts the auth secret token on the runtime so that later during the run method of MPI runtime handler _generate_mpi_job and _configure_pod_template can copy these volumes/volume mounts into the launcher/worker pod template. This allows the mpi pods to authentication with mlrun.

The auth token is already saved as part of the run's spec during the _enrich_run of the ServerSideLauncher.


🛠️ Changes Made

  • Add token_name and auth_info to add_secrets_to_spec_before_running() in mpi runtime handler run() method

✅ Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR
  • I confirmed whether my changes are covered by system tests
    • If yes, I ran all relevant system tests and ensured they passed before submitting this PR
    • I updated existing system tests and/or added new ones if needed to cover my changes
  • If I introduced a deprecation:

🧪 Testing

Manual test in IG4 + ran system test on IG3


🔗 References


🚨 Breaking Changes?

  • Yes (explain below)
  • No

🔍️ Additional Notes

…o to add_secrets_to_spec_before_running so the secret token is translated to volumes/mounts on the runtime, which are then copied during the CRD creations
@elbamit elbamit marked this pull request as ready for review December 18, 2025 07:18
@elbamit elbamit requested a review from a team as a code owner December 18, 2025 07:18
@liranbg liranbg merged commit 588c4b6 into mlrun:development Dec 18, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants