Skip to content

Conversation

@davesh0812
Copy link
Contributor

@davesh0812 davesh0812 commented Dec 17, 2025

📝 Description

  1. When calling _is_directory_in_range, either the start or end must exist, so now we retrieve the timezone from whichever one is available.
  2. Adding check if start_time or end_time where given before calling to the new optimized flow

🛠️ Changes Made


✅ Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR
  • I confirmed whether my changes are covered by system tests
    • If yes, I ran all relevant system tests and ensured they passed before submitting this PR
    • I updated existing system tests and/or added new ones if needed to cover my changes
  • If I introduced a deprecation:

🧪 Testing

Added unit test


🔗 References


🚨 Breaking Changes?

  • Yes (explain below)
  • No

🔍️ Additional Notes

@davesh0812 davesh0812 requested a review from gtopper December 17, 2025 15:21
@davesh0812 davesh0812 requested a review from gtopper December 17, 2025 15:44
Copy link
Collaborator

@gtopper gtopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davesh0812 davesh0812 merged commit 5f24bcf into mlrun:1.10.x Dec 17, 2025
18 checks passed
davesh0812 added a commit to davesh0812/mlrun that referenced this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants