Skip to content

Conversation

@liranbg
Copy link
Member

@liranbg liranbg commented Dec 14, 2025

๐Ÿ“ Description

OVERWRITE_IMAGE_REGISTRY is optional. not always needed. when not provided, use docker_registry to pull kfp image from.


๐Ÿ› ๏ธ Changes Made

  • use .get instead of direct access to avoid key error

โœ… Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR
  • I confirmed whether my changes are covered by system tests
    • If yes, I ran all relevant system tests and ensured they passed before submitting this PR
    • I updated existing system tests and/or added new ones if needed to cover my changes
  • If I introduced a deprecation:

๐Ÿงช Testing

manual patching


๐Ÿ”— References

  • Ticket link:
  • Design docs links:
  • External links:

๐Ÿšจ Breaking Changes?

  • Yes (explain below)
  • No

๐Ÿ”๏ธ Additional Notes

Copy link
Member

@Yacouby Yacouby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for better readability

Copy link
Member

@Yacouby Yacouby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better ๐Ÿ‘

@liranbg liranbg merged commit 722fc9c into mlrun:development Dec 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants