[Serving] Add support for input as a Batch (without model monitoring) #9053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerm-iguazio
requested review from
a team,
TomerShor and
liranbg
as code owners
royischoss
reviewed
Dec 15, 2025
Contributor
royischoss
left a comment
royischoss
left a comment
There was a problem hiding this comment.
Hey looks nice please add a test that checks the error raiser functionality, if needed add a commit in storey to support the error you want to raise on a batch, added another small comment on the model you created
| def predict(self, body, **kwargs): | ||
| x = pd.DataFrame(body) | ||
| predictions = self.model.predict(x).tolist() | ||
| return [round(v, 6) for v in predictions] |
Contributor
There was a problem hiding this comment.
please add a model that uses format_batch and show functionality
Contributor
Author
There was a problem hiding this comment.
added, tnx! (also for the system test).
# Conflicts: # tests/serving/test_async_flow.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Add support for input as a batch in ModelRunnerErrorRaiser and add
format_batchclient function.Update body parameter type.
Important note:
Batch support in model monitoring will be added in a follow-up PR and is not supported yet.
🛠️ Changes Made
✅ Checklist
🧪 Testing
Add unit tests + system tests.
🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes