Skip to content

Commit ad7ea62

Browse files
authored
[Automation] Fix application runtime system probes system test (#9175)
### πŸ“ Description - Remove redundant image explicit configuration from the sidecar container --- ### πŸ› οΈ Changes Made - Fixed the `spec.sidecars` in the test's helper function --- ### βœ… Checklist - [ ] I updated the documentation (if applicable) - [x] I have tested the changes in this PR - [x] I confirmed whether my changes are covered by system tests - [x] If yes, I ran all relevant system tests and ensured they passed before submitting this PR - [x] I updated existing system tests and/or added new ones if needed to cover my changes - [ ] If I introduced a deprecation: - [ ] I followed the [Deprecation Guidelines](./DEPRECATION.md) - [ ] I updated the relevant Jira ticket for documentation --- ### πŸ§ͺ Testing <!-- - How it was tested (unit tests, manual, integration) --> <!-- - Any special cases covered. --> --- ### πŸ”— References - Ticket link: https://iguazio.atlassian.net/browse/ML-11943 - Design docs links: - External links: https://github.com/mlrun/mlrun/actions/runs/20734626464/job/59529957989#step:12:1601 --- ### 🚨 Breaking Changes? - [ ] Yes (explain below) - [x] No <!-- If yes, describe what needs to be changed downstream: --> --- ### πŸ”οΈ Additional Notes <!-- Anything else reviewers should know (follow-up tasks, known issues, affected areas etc.). --> <!-- ### πŸ“Έ Screenshots / Logs -->
1 parent a8c1684 commit ad7ea62

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

β€Žtests/system/runtimes/test_application.pyβ€Ž

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -274,13 +274,11 @@ def _create_delay_health_check_application(self, name="delay-app"):
274274
function.spec.args = [
275275
"-m",
276276
"flask",
277+
"--app=function_with_delay_healthcheck",
277278
"run",
278279
"--host=0.0.0.0",
279280
"--port=5000",
280281
]
281-
function.spec.env = [
282-
{"name": "FLASK_APP", "value": "function_with_delay_healthcheck.py"}
283-
]
284282
function.with_http(workers=1, trigger_name="application-http")
285283
delay_healthcheck_source = os.path.join(
286284
self.remote_code_dir, self._function_with_delay_healthcheck
@@ -289,14 +287,6 @@ def _create_delay_health_check_application(self, name="delay-app"):
289287
function.spec.config["spec.sidecars"] = [
290288
{
291289
"name": f"{function.metadata.name}-sidecar",
292-
"image": f".mlrun/func-{self.project.metadata.name}-{function.metadata.name}:latest",
293-
"ports": [
294-
{
295-
"containerPort": 5000,
296-
"name": "application-t-0",
297-
"protocol": "TCP",
298-
}
299-
],
300290
"readinessProbe": {"httpGet": {"path": "/health", "port": 5000}},
301291
}
302292
]

0 commit comments

Comments
Β (0)