Fix compilation of Save() when HDF5 is enabled
#3942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This will require a bugfix release once it's merged. |
shrit
approved these changes
May 15, 2025
shrit
approved these changes
May 16, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While compiling Python bindings on a system that had HDF5 enabled, I encountered a compilation failure:
http://ci.mlpack.org/job/mlpack-wheels/111/pipeline-console/?selected-node=67
Uh, it's really hard to find the failure in there, but basically in
SaveMatrix(), whenARMA_USE_HDF5is set, then thefilenameparameter doesn't exist. So I threaded thefilenameparameter throughSaveDense()andSaveSparse()to fix the issue.The reason that
filenameis needed is that Armadillo doesn't support saving HDF5 to streams---it only saves to filenames.CC: @shrit because this is related to #3927.