-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Shuffle sequence lengths #3926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shuffle sequence lengths #3926
Conversation
shuffle with the rest of the data
use arma traits like the rest of the file
rcurtin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent catch and thanks for the great patch @nzachary! Two quick comments before merge; let me know what you think.
rcurtin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @nzachary!
|
One thing I forgot to write, if you want to add a note to |
rcurtin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry---forgot to kick off the build. It looks like one of the new tests is failing; can you look into that? Thanks!
|
not sure why that last test failed. my changes shouldn't affect it and all tests passed on my machine |
rcurtin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry about the cross-compilation test; you're right that it has nothing to do with your code. Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second approval provided automatically after 24 hours. 👍
|
Thanks again @nzachary! |
I noticed that rnns don't shuffle the sequence lengths with the data/labels
This pr should fix that