Skip to content

Conversation

@nzachary
Copy link
Member

I noticed that rnns don't shuffle the sequence lengths with the data/labels

This pr should fix that

shuffle with the rest of the data
use arma traits like the rest of the file
@nzachary nzachary changed the title Sequence length shuffle Shuffle sequence lengths Apr 17, 2025
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch and thanks for the great patch @nzachary! Two quick comments before merge; let me know what you think.

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @nzachary!

@rcurtin
Copy link
Member

rcurtin commented Apr 18, 2025

One thing I forgot to write, if you want to add a note to HISTORY.md and add your name to the list of authors in COPYRIGHT.txt, please do feel free! And, the Github action I have set up to do this is not currently working, but, it is supposed to post a message saying that if you want mlpack or ensmallen stickers to put on your laptop, send a mailing address to [email protected] and one of us will throw some stickers in the mail for you. 👍

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry---forgot to kick off the build. It looks like one of the new tests is failing; can you look into that? Thanks!

@nzachary
Copy link
Member Author

nzachary commented Apr 19, 2025

not sure why that last test failed. my changes shouldn't affect it and all tests passed on my machine

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about the cross-compilation test; you're right that it has nothing to do with your code. Thanks again!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@conradsnicta conradsnicta merged commit 6efbe25 into mlpack:master Apr 21, 2025
14 of 15 checks passed
@rcurtin
Copy link
Member

rcurtin commented Apr 21, 2025

Thanks again @nzachary!

@nzachary nzachary deleted the ragged-shuffle branch April 22, 2025 04:34
@rcurtin rcurtin mentioned this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants