Put mutexes under a preprocessed condition. #3868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable to compile the code if in some cases you do not have mutex support in the standard library. Assuming you have one core as well. Signed-off-by: Omar Shrit <[email protected]>
rcurtin
reviewed
Jan 8, 2025
Signed-off-by: Omar Shrit <[email protected]>
rcurtin
reviewed
Jan 8, 2025
Member
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
This looks great to me. I guess we don't really have any style rules for how to put #ifdefs inside the code... to me it looks a little ugly with the indentation but I have no other suggestion. So I think it is just fine 😄
Co-authored-by: Ryan Curtin <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
eddelbuettel
reviewed
Jan 8, 2025
rcurtin
approved these changes
Jan 8, 2025
Member
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Looks great. Want to add an entry to HISTORY.md indicating that we added the MLPACK_NO_STD_MUTEX definition for disabling use of std::mutex?
Signed-off-by: Omar Shrit <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
eddelbuettel
approved these changes
Jan 10, 2025
This was referenced Mar 31, 2025
Closed
Closed
Merged
conradsnicta
reviewed
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable to compile the code if in some cases you do not have mutex support in the standard library. Assuming you have one core as well.