Fix compilation errors with clang 19 #3799
Conversation
marlamb
force-pushed
the
feature/fix-compilation-errors-with-clang-19
branch
from
051d725 to
2965954
Compare
|
Thank you, you are a hero! I had seen these errors in the CRAN logs but had not yet been able to address them. So this takes something off my todo list. I may add the I'll approve once I see the build succeeds (it should, you didn't make any breaking changes as far as I can tell. Could take a few minutes though). Thanks again! 🚀 |
|
Always an honor to contribute to a well maintained open source library! Edit: Looks like it is now green by retriggering 😃 . Looking forward to getting it merged! |
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Thanks again! Feel free to add your name to the list of contributors and update the HISTORY.md file, or, I'll push a commit to HISTORY.md to document the change before merge. 👍
The new compiler version seems to perform more exhaustive checks on templates, even if they are not initiated. As the code was malformed also before, it is likely that it is dead code. However, this commit is mainly to ensure users using clang 19 can include the header without compilation error. Note that this commit does not guarantee that currently other code might not compile with clang 19, it just fixes some code which was used transitevily and caused problems.
marlamb
force-pushed
the
feature/fix-compilation-errors-with-clang-19
branch
from
2965954 to
90b8d28
Compare
Done, hope the very short description in the |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thanks again @marlamb! Our github-actions scripts are supposed to offer you stickers for your laptop now, but I think it is not working right (I have to go debug it...), so anyway, if you want some stickers, send your mailing address to [email protected] and we'll get some in the mail. 👍 |
3 participants
The new compiler version seems to perform more exhaustive checks on templates, even if they are not initiated. As the code was malformed also before, it is likely that it is dead code. However, this commit is mainly to ensure users using clang 19 can include the header without compilation error.
Note that this commit does not guarantee that currently other code might not compile with clang 19, it just fixes some code which was used transitevily and caused problems.