updated some errors from previous pr on adapting nearest interpolation #3768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andrewfurey21
commented
Jul 17, 2024
andrewfurey21
commented
- Updated HISTORY.md
- Added note on generalizing for 1d, 2d and 3d
- Updated inputDimensions size check
shrit
reviewed
Jul 19, 2024
shrit
approved these changes
Jul 22, 2024
Member
|
@rcurtin I think the failing tests are not related, or maybe because this was before merging with the master |
rcurtin
requested changes
Jul 22, 2024
Member
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Thanks for the update @andrewfurey21; my comments should be pretty easy to address. If you merge master into this branch, it should fix the test failures (this will get you the fixes from #3769).
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rcurtin
approved these changes
Jul 29, 2024
Member
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Thanks for the cleanups and fixes @andrewfurey21 👍 It looks good to me. I have one suggested improvement for the error message; if you can either accept the suggestion or make a similar change before merge, I would appreciate it.
shrit
approved these changes
Aug 26, 2024
This was referenced Sep 16, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.