Bump minimum Armadillo version to 10.8 #3760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2024
Member
|
Looks good; we can also remove these legacy workarounds now: $ grep -r ARMA_VERSION .
./mlpack/core/util/arma_traits.hpp:#if ((ARMA_VERSION_MAJOR >= 10) || \
./mlpack/core/util/arma_traits.hpp: ((ARMA_VERSION_MAJOR == 9) && (ARMA_VERSION_MINOR >= 869)))
./mlpack/bindings/go/mlpack/capi/arma_util.hpp: #if ARMA_VERSION_MAJOR >= 10
./mlpack/bindings/python/mlpack/arma_util.hpp: #if ARMA_VERSION_MAJOR >= 10
./mlpack/bindings/julia/julia_util.cpp: #if ARMA_VERSION_MAJOR >= 10
./mlpack/bindings/julia/julia_util.cpp: #if ARMA_VERSION_MAJOR >= 10
./mlpack/bindings/julia/julia_util.cpp: #if ARMA_VERSION_MAJOR >= 10
./mlpack/bindings/julia/julia_util.cpp: #if ARMA_VERSION_MAJOR >= 10
./mlpack/bindings/julia/julia_util.cpp: #if ARMA_VERSION_MAJOR >= 10
./mlpack/bindings/julia/julia_util.cpp: #if ARMA_VERSION_MAJOR >= 10
./mlpack/bindings/julia/julia_util.cpp: #if ARMA_VERSION_MAJOR >= 10I think we will have to wait on the ensmallen version to get bumped but that shouldn't take long. |
Contributor
Author
|
@rcurtin legacy workarounds removed |
shrit
previously requested changes
Jul 11, 2024
Member
shrit
left a comment
shrit
left a comment
There was a problem hiding this comment.
Requesting change so we fix the CI before
rcurtin
approved these changes
Jul 12, 2024
Member
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Thanks, everything looks great. I pushed some simple changes to update the version used in CI; I'll work to get everything green there.
Member
|
@mlpack-jenkins test this please |
zoq
approved these changes
Jul 13, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump minimum Armadillo version to 10.8.
This allows using the numerous Armadillo API additions and enhancements since 9.800. It also allows assuming throughout the mlpack codebase that matrices are initialised to zero by default.
Current state of Armadillo versions in various distros:
Related: mlpack/ensmallen#404