Distribute patched STB with R package #3726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tf() usage in STB.
Contributor
|
Shouldn't the modified |
Member
Author
|
I just copy it from wherever CMake found it at the top level (e.g. |
eddelbuettel
approved these changes
May 31, 2024
Contributor
eddelbuettel
left a comment
eddelbuettel
left a comment
There was a problem hiding this comment.
Should be good to go provided the file good so 🚢
Contributor
|
Kudos!
|
coatless
approved these changes
May 31, 2024
This was referenced Sep 16, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to knock this out during a meeting. The changes are pretty simple:
stb_image.handstb_image_write.has part of the R package distribution. This is important because we are not guaranteed that a user has these present on their system (which I think will cause a package installation failure if they don't).sprintf()insidestb_image_write.htosnprintf(). This is actually already done in a slightly different way in an open STB patch, although that still leaves ansprintf()call in, so maybe the patch I did is better, at least for CRAN.I patched this locally in the version of mlpack I just submitted to CRAN.
This fixes #3724.