Coot15, Do not use the transform function if we are using bandicoot in softmax layer #3683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omar Shrit <[email protected]>
shrit
commented
Apr 10, 2024
| MatType maxInput = repmat(max(input), input.n_rows, 1); | ||
| output = (maxInput - input); | ||
| output = exp(output * -1); | ||
| maxInput.each_row() += log(sum(output)); |
Member
Author
There was a problem hiding this comment.
technically, we still do not have an each_row() function in bandicoot
Member
There was a problem hiding this comment.
Yes, it is possible and on my todo list though. (Soon enough... 😄)
Signed-off-by: Omar Shrit <[email protected]>
rcurtin
approved these changes
Apr 11, 2024
Member
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Looks good to me, although we won't really be able to test it until everything else is in place.
Co-authored-by: Ryan Curtin <[email protected]>
Co-authored-by: Ryan Curtin <[email protected]>
Co-authored-by: Ryan Curtin <[email protected]>
Co-authored-by: Ryan Curtin <[email protected]>
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MarkFischinger please feel free to open a PR to replace the current implementation with Padé