Skip to content

Conversation

@coatless
Copy link
Contributor

Fixes deprecation of @docType package by using "_PACKAGE".

✖ package.R:15: `@docType "package"` is deprecated.
ℹ Please document "_PACKAGE" instead.

Fixes deprecation of `@docType package` by using `"_PACKAGE"`.

```
✖ package.R:15: `@docType "package"` is deprecated.
ℹ Please document "_PACKAGE" instead.
```
@coatless coatless changed the title Update roxygen2 package-level documentation entry [R] Update roxygen2 package-level documentation entry Feb 24, 2024
@coatless
Copy link
Contributor Author

We probably should also bump the version of Rcpp required to be greater than v1.0.0 as well...

Copy link
Contributor

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

#' @importFrom Rcpp evalCpp
#' @useDynLib mlpack
NULL
"_PACKAGE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I needed that in some places and truly hate how some package force you to make such minutae changes.

@eddelbuettel
Copy link
Contributor

We probably should also bump the version of Rcpp required to be greater than v1.0.0 as well...

Or just remove the version argument as all recent ones are good.

Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@coatless coatless merged commit d971613 into master Feb 26, 2024
@coatless coatless deleted the coatless-patch-1 branch February 26, 2024 00:20
This was referenced May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants