Using, std:: for standard library functions that does not have any.
#3629
Conversation
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Nice, there are actually fewer changes here than I was expecting. All my comments are pretty trivial. 👍
| { | ||
| const size_t n = static_cast<size_t> | ||
| (ceil((-1. + sqrt(1. + 8. * input.n_elem)) / 2.)); | ||
| (ceil((-1. + std::sqrt(1. + 8. * input.n_elem)) / 2.)); |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes had the same thing in some kernels
Co-authored-by: Ryan Curtin <[email protected]>
Co-authored-by: Ryan Curtin <[email protected]>
Co-authored-by: Ryan Curtin <[email protected]>
Co-authored-by: Ryan Curtin <[email protected]>
Co-authored-by: Ryan Curtin <[email protected]>
|
@rcurtin sometime to be honest we can leave it at 81 char per lines, unless if you are very strict about it and we should break after 80 cols |
Co-authored-by: Ryan Curtin <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Sorry, as you know, I am quite pedantic, and we should stick to 80 throughout 😄 I need to look into the style checks---they should catch these issues but right now they aren't. I just haven't had time to do it. |
3 participants
Hi,
This PR added
std::for the standard library functions, mostly from cmath header.These functions are called without specifying the namespace which is causing a problem with the integration.