S01E07 Adding the last missing part from arma::Mat to MatType and from arma::Cube to CubeType
#3609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omar Shrit <[email protected]>
rcurtin
reviewed
Jan 20, 2024
Member
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Looking good, some small thoughts on cleanups and other minor issues.
src/mlpack/methods/ann/activation_functions/identity_function.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
rcurtin
approved these changes
Jan 23, 2024
Member
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Just a couple other thoughts before merge. The extra CubeType should probably be removed before merge, but the other one is up to you. I am assuming it should pass all the related tests (worth double-checking first :)).
Signed-off-by: Omar Shrit <[email protected]>
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
This was referenced May 26, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the last part of converting
arma::Matandarma::CubetoMatTypeandCubeTypein the ANN code base. In the next PR we will start addressingarma::Col