Apply ADL on arma::function -> function
#3605
Conversation
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
This reverts commit bb04cf3.
This reverts commit 32d9a7f.
This reverts commit e25e4e2.
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
|
@rcurtin I think this is enough for this PR, let us see if all passes, I tried to fix some of the styles that I have seen, but it is not easy to visualize all with |
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Took a long time to get through, but all the changes are really simple and it looks like they all compile fine. I think the code is a little easier to read now too, without arma:: everywhere (or at least, with fewer of them 😄). The cross-compilation check is failing with the same unknown argument -EL that we saw in a previous PR, but that seems quite unrelated to these changes. It would be cool if we could figure that out sometime but certainly no need to stop these changes based on that. 👍
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
2 participants
Hi,
This is a set of functions that works with ADL and compiles on my machine.
The following does not work with ADL:
as_scalarmeanLet us see if this is passes on Windows