Coot E01S03 #3602
Coot E01S03 #3602
Conversation
Signed-off-by: Omar Shrit <[email protected]>
|
hmm, this is not throwing any error locally, probably C++ version issue |
Signed-off-by: Omar Shrit <[email protected]>
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Nice, I think because the actual initialization functions use functions that are available in both Armadillo and Bandicoot that after this change things should work for Bandicoot too (once the IsMat and IsCube classes accept Bandicoot types, that is).
It looks like MSVC and the memory check job hiccup on the template SFINAE argument; I think the suggestion of typename = typename std::enable_if_t<...> should fix that. But, there are lots of ways to do it, template argument SFINAE is only one possibility (you could also use return type SFINAE or argument SFINAE...); up to you how you want to fix it, don't feel obligated to take my suggestion. 👍
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
|
This one should pass now, as it is the case on my machine. Let us merge it asap. |
Co-authored-by: Ryan Curtin <[email protected]>
Co-authored-by: Ryan Curtin <[email protected]>
Co-authored-by: Ryan Curtin <[email protected]>
Co-authored-by: Ryan Curtin <[email protected]>
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
Signed-off-by: Omar Shrit <[email protected]>
2 participants
Prepare the following function signature for coot.
In the first PR, we will adapt it and add additional
std::enable_if_t<IsCoot>to make work in that case.