Reduce random failures for DecisionTreeRegressor tests #3594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrit
approved these changes
Jan 5, 2024
Member
shrit
left a comment
shrit
left a comment
There was a problem hiding this comment.
Looks good to me, and the tests are passing
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows multiple trials for the
DecisionTreeRegressortests. I found them to be failing at the rate of about one every hundred times. With these fixes, I saw no failures at all with 1000 different random seeds.I also combined one of the tests that had both an
fmatand amatversion into a single test usingTEMPLATE_TEST_CASE(). That required some slight changes to some of the test tools.