Change the template type from arma::mat to MatType in NS #3567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
rcurtin
reviewed
Dec 4, 2023
Member
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Thanks, want to add a super basic test using KNN with a float element type? The changes themselves look great to me, it would just be nice to test them also. 👍
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
Signed-off-by: Omar Shrit <[email protected]>
rcurtin
approved these changes
Dec 12, 2023
Member
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for adding the test! 👍
|
|
||
| template<typename MetricType, typename StatisticType, typename MatType> | ||
| using FloatKDTree = BinarySpaceTree<MetricType, StatisticType, MatType, | ||
| FloatHRectBound, MidpointSplit>; |
Member
There was a problem hiding this comment.
I am trusting that you will come back later and refactor the bounds 😄
Member
Author
There was a problem hiding this comment.
I have to do so, but I will need some time 👍
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
This was referenced May 26, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.