detect C++17 mode in MSVC #3555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrit
approved these changes
Oct 28, 2023
Member
shrit
left a comment
shrit
left a comment
There was a problem hiding this comment.
Looks good to me. However, I do not have any Windows machine to test it, but give that it passed the tests then it should be fine
rcurtin
reviewed
Oct 28, 2023
Co-authored-by: Ryan Curtin <[email protected]>
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for the byzantine ways of enabling C++17 mode in the MSVC "compiler".
MSVC uses a custom macro named
_MSVC_LANGin addition to (or instead of) the standard__cplusplusmacro, depending on how the user enabled C++17 mode (which itself can be confusing).Related to #3549