Skip to content

Conversation

@rcurtin
Copy link
Member

@rcurtin rcurtin commented May 29, 2023

This allows users to pass categorical matrices to the preprocess_one_hot_encoding binding. This is actually a transparent change, so all user code can remain the same. But whereas in Python a user would previously call preprocess_one_hot_encoding(input=dataset), now that parameter dataset can also be a pandas DataFrame whose columns can have any type, instead of just a numpy ndarray or similar.

By default, if the dimensions parameter is not specified (it is no longer required), all categorical dimensions are one-hot encoded.

This addresses #3480.

There will need to be a new release of mlpack before this becomes available in PyPI or conda (or other languages' package managers).

Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@conradsnicta conradsnicta merged commit 97fa8af into mlpack:master Jun 9, 2023
This was referenced Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants