Skip to content

Conversation

@DiscreteLogarithm
Copy link
Contributor

@DiscreteLogarithm DiscreteLogarithm commented May 16, 2023

Several initialization classes were missing the serialize method. Without it neural networks that use these init rules cannot be serialized.

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for adding these! If you want to add a note to HISTORY.md please feel free. 👍

@DiscreteLogarithm
Copy link
Contributor Author

Thank you for the great software you've developed. I added a note but if you think it's too lengthy please feel free to edit it.

Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@conradsnicta conradsnicta merged commit 4097d3a into mlpack:master May 18, 2023
@DiscreteLogarithm DiscreteLogarithm deleted the add-serialize-to-init-rules branch May 18, 2023 17:51
This was referenced Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants