Skip to content

Conversation

@mrdaybird
Copy link
Contributor

@mrdaybird mrdaybird commented Apr 11, 2023

Fixes #3466

  • Fix PReLU
  • Add tests

@mrdaybird
Copy link
Contributor Author

@rcurtin I have added the tests as well. If you have any suggestions, do share.

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix. Nice integration test, by the way.

Want to add something to HISTORY.md? If not I'll handle it during merge. All of my.comments are tiny style fixes. 👍

Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rcurtin rcurtin merged commit 417ba39 into mlpack:master Apr 28, 2023
This was referenced Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parameteric ReLU only applied when training?

3 participants