Update outdated codes in cf.md and datasetmapper.md #3398
Conversation
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Thanks again, I love that you are going through all the documentation and finding issues like this. 👍
doc/tutorials/cf.md
Outdated
| // The constructor takes a default-constructed factorizer, which, by default, | ||
| // is of type NMFALSFactorizer. | ||
| CF cf(data, NMFALSFactorizer(), neighborhood, rank); | ||
| CFType cf(data, NMFPolicy(), neighborhood, rank); |
There was a problem hiding this comment.
I thought that CF was typedef'ed to CFType<> (the default), but it seems like that code is not actually there in src/mlpack/methods/cf/cf.hpp! Do you want to instead add that typedef, and then this change shouldn't be needed?
There was a problem hiding this comment.
Yes, I had added that typedef.
| std::cout << info.UnmapValue("T", 2) << "\n"; | ||
| std::cout << info.UnmapValue("F", 2) << "\n"; | ||
| std::cout << info.UnmapValue("True", 2) << "\n"; | ||
| std::cout << info.UnmapValue("False", 2) << "\n"; |
There was a problem hiding this comment.
Thanks, nice catch on this one. 👍
Change inorder to make CF typedef from CFType
|
One thing I want to ask |
Sure, if you see an easy way to hook it up, feel free! That would definitely be worth an entry in |
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Thanks, just one final comment. :)
doc/tutorials/cf.md
Outdated
| - `QUIC_SVD` | ||
| - `BiasSVD` | ||
| - `SVDPlusPlus` | ||
| - `RandomizedSVD` |
There was a problem hiding this comment.
I took a look and I think these names don't actually correspond to what's used in the code. So instead of RandomizedSVD, we should have RandomizedSVDPolicy, etc.; I think there are errors in what was already there before too.
|
suggest to also add a corresponding item to HISTORY.md |
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
Co-authored-by: Ryan Curtin <[email protected]>
|
Thanks so much! |
3 participants
No description provided.