Pixel shuffle Layer #2833
Pixel shuffle Layer #2833
Conversation
Updated Cereal_nvp
Added pixel shuffle to more_types
|
@zoq @kartikdutt18 Are there any more changes required in this pr. |
kartikdutt18
left a comment
kartikdutt18
left a comment
There was a problem hiding this comment.
Hey @abh2k, These are minor changes and a point to discuss on. Thanks for taking the time to create the PR.
Regards.
| arma::mat inputImage = input.col(n); | ||
| arma::mat outputImage = output.col(n); | ||
| arma::cube inputTemp(const_cast<arma::mat&>(inputImage).memptr(), height, | ||
| width, size, false, false); | ||
| arma::cube outputTemp(const_cast<arma::mat&>(outputImage).memptr(), | ||
| outputHeight, outputWidth, sizeOut, false, false); |
There was a problem hiding this comment.
I'm not sure about this but maybe we can do this without the creating copies (which add to latency / space utilization). If
arma::cube inputTemp(const_cast<arma::mat&>(input.col(n)).memptr(), height,
width, size, false, false);
doesn't work, we can
arma::cube inputTemp(const_cast<arma::mat&>(input).memptr(), height,
width, size * batchSize, false, false);
and then use span. That way we don't create copies.
Also save time on copying back (maybe). Let me know incase I missed something.
There was a problem hiding this comment.
@kartikdutt18 @zoq I made the required changes. Now the copying step has been removed. Please review.
kartikdutt18
added
c: methods
t: added feature
and removed
s: unanswered
s: unlabeled
labels
Co-authored-by: kartikdutt18 <[email protected]>
abh2k
force-pushed
the
pixel_shuffle
branch
2 times, most recently
from
075881a to
7b70a82
Compare
kartikdutt18
left a comment
kartikdutt18
left a comment
There was a problem hiding this comment.
Looks good to me!
Thanks a lot for the contribution.
Regards.
| @@ -0,0 +1,180 @@ | |||
| /** | |||
| * @file methods/ann/layer/pixel_shuffle.hpp | |||
| * @author Anjishnu Mukherjee | |||
There was a problem hiding this comment.
Feel free to add yourself as co-author.
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
5 participants
Added pixel shuffle layer