Soft Margin Loss function #2494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like the notebook is private? |
Member
Author
Updated the link. Thanks! |
birm
approved these changes
Jul 26, 2020
Member
birm
left a comment
birm
left a comment
There was a problem hiding this comment.
I don't know what's caused the style build to suddenly care about another file.
That said, this is good work. I like the new standard(?) of having a colab notebook to show correctness. Great work!
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
Member
Author
|
Thanks for reviewing and merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue : #2200
PyTorch docs : here
To compare bare-bones armadillo implementation with PyTorch implementation, see this Google Colab notebook.