Removed r-value references from remaining functions [and some style fixes] #2292
Conversation
kartikdutt18
changed the title
|
I think the build is fine, no relevant test has failed that is related to this PR. |
rcurtin
left a comment
rcurtin
left a comment
There was a problem hiding this comment.
Whew, the build failures are not looking good today. Interestingly the fixes you have here actually did not cause a build failure, because HardShrink and LogCoshLoss were never actually tested as part of an FFN.
Anyway, I looked through all the build output and all failures are either:
So it seems good to merge to me. 👍 Thanks for the fixes!
|
Yeah, I think they were merged when your PR was already open so I think they weren't changed. Also I went through the repo twice to ensure that there are no other functions / layers that need to be refactored so I guess we have completely removed r-values references in ann (for arma datatypes). |
|
Thanks! I think you might be more on top of things than I am. 😄 |
|
Thanks a lot! Happy to help in anyway I can. |
favre49
left a comment
favre49
left a comment
There was a problem hiding this comment.
Thanks for being so quick on this :)
|
Thanks a lot! |
3 participants
closes #2287.
I have made changes to remove r-value from remaining functions. There were also some style changes that I thought should be made so I have also made them. I hope that's okay. I can also open another PR for style but since they were simple enough I've made them in this PR.
Thanks.