Fixed markdown pipe symbol issue #2280
Conversation
|
This looks good from my end; what testing have you done? |
Well, I made the markdown locally, and checked if the problems @rcurtin specified in the issue were resolved with the help of a kramdown editor. Since I saw they were, I went ahead with this pull request. |
birm
left a comment
birm
left a comment
There was a problem hiding this comment.
Yes, from my end, it looked to resolve the issue perfectly. Thanks for a clever and compact solution!
|
Hey there @birm , sorry, but I just noticed I left an extra "endl" right after printing the description. Just a heads up before I make a commit to fix the same. Also, thanks for the kind words. Means a lot to me :) |
birm
left a comment
birm
left a comment
There was a problem hiding this comment.
ok, I'll mark it as a requested change until it's removed
|
Thank you, I've made the commit. 👍 |
|
@rcurtin mlpack bot broken again? :) |
favre49
left a comment
favre49
left a comment
There was a problem hiding this comment.
Looks fine to me, providing second approval
4 participants
This hopefully fixes issue #2270 (escaping does work in kramdown! :)). This should take care of the "|" symbol issue in the markdown for all bindings.