-
Notifications
You must be signed in to change notification settings - Fork 135
Bump minimum Armadillo version to 10.8 #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like the docker images to build uses an older version, will update it tomorrow. |
|
@zoq Sounds good. |
shrit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I will approve it after the CI has passed
|
Thanks for all the ifdef cleanups---I didn't realize there was so much of that going on in ensmallen. I'll approve too once we get CI passing and then we can get this merged and a new release out. 👍 |
|
Perfect, I just need to rebuild the docker image that we use on the jenkins server, and that should fix the |
|
@zoq Do you mean updating the Ubuntu image? I think the current image uses the old Ubuntu 20.04 release which only has armadillo 9.800.4 |
Right, updated the image. |
|
@mlpack-jenkins test this please |
2 similar comments
|
@mlpack-jenkins test this please |
|
@mlpack-jenkins test this please |
|
@conradsnicta oh, you're right, I need to add the Github actions script to this repo too. (Basically I went to update mlpack-bot because it stopped working, then it turned out everything it was built on was deprecated, and so in the end I rewrote its functionality as a Github action.) |
Bump minimum Armadillo version to 10.8.2.
This allows using the numerous Armadillo API additions and enhancements since 9.800. It also allows assuming throughout the ensmallen codebase that matrices are initialised to zero by default.
Current state of Armadillo versions in various distros:
Related: mlpack/mlpack#3760