Skip to content

docs: add STATE-001 and #209 lessons; archive HOST-002 and STATE-001 specs#225

Merged
mlorentedev merged 1 commit into
masterfrom
chore/housekeeping-lessons-and-specs
Jun 26, 2026
Merged

docs: add STATE-001 and #209 lessons; archive HOST-002 and STATE-001 specs#225
mlorentedev merged 1 commit into
masterfrom
chore/housekeeping-lessons-and-specs

Conversation

@mlorentedev

@mlorentedev mlorentedev commented Jun 26, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary

Checklist

  • No code changes — docs and spec housekeeping only
  • Lesson style matches existing entries (bold rule, context, generalized takeaway)
  • Both archived proposal.md files updated to status: archived

Closes #207

Summary by CodeRabbit

  • Documentation

    • Added new lesson notes covering safer default state storage and clearer config validation behavior.

  • Chores

    • Marked two archived spec proposals as completed in the project documentation.

@mlorentedev
docs: add STATE-001 and #209 lessons; archive HOST-002 and STATE-001 …
fd91c15 
…specs

Add two lessons to docs/lessons.md (2026-06-24 block):
- CWD-relative state paths leak node identity into git (STATE-001 / #207)
- Reject structurally impossible config combinations at load time (#209)

Archive specs whose PRs are merged:
- specs/STATE-001-fixed-per-user-state-dir -> specs/archive/ (PR #219)
- specs/HOST-002-config-precedence-and-windows-ci -> specs/archive/ (issue #193 closed)
@coderabbitai

coderabbitai Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 975094dc-7802-4601-b3db-85b8ad2560f3

📥 Commits

Reviewing files that changed from the base of the PR and between f301741 and fd91c15.

📒 Files selected for processing (8)
  • docs/lessons.md
  • specs/archive/HOST-002-config-precedence-and-windows-ci/proposal.md
  • specs/archive/HOST-002-config-precedence-and-windows-ci/tasks.md
  • specs/archive/HOST-002-config-precedence-and-windows-ci/verification.md
  • specs/archive/STATE-001-fixed-per-user-state-dir/features.json
  • specs/archive/STATE-001-fixed-per-user-state-dir/proposal.md
  • specs/archive/STATE-001-fixed-per-user-state-dir/tasks.md
  • specs/archive/STATE-001-fixed-per-user-state-dir/verification.md
📝 Walkthrough

Walkthrough

Added lesson notes for state-directory defaults and config-load validation, and changed two archived proposal specs so their front-matter status is archived.

Changes

Lesson notes

Layer / File(s) Summary
Lesson bullets for state dir and control-plane validation
docs/lessons.md		 Adds two 2026-06-24 lesson bullets describing the absolute per-user state directory default and config-load validation for control-plane key and TS_CONTROL_URL combinations.

Archived proposal metadata

Layer / File(s) Summary
Archived proposal statuses
specs/archive/HOST-002-config-precedence-and-windows-ci/proposal.md, specs/archive/STATE-001-fixed-per-user-state-dir/proposal.md		 Changes the front-matter status field in both archived proposal specs to archived.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

A rabbit hopped by under moonlit trees,
With tidy docs and archived pleas.
The burrow stays per-user now,
And config rules wear a clearer brow.
🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning It includes a summary and partial checklist, but it omits the template's Changes, Testing, and Type sections. Add a Changes section, the Testing checklist items, and the Type section with the appropriate checkbox selected.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the main change: adding lessons and archiving two specs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/housekeeping-lessons-and-specs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mlorentedev
mlorentedev merged commit 361e5e6 into master Jun 26, 2026
13 checks passed
@mlorentedev
mlorentedev deleted the chore/housekeeping-lessons-and-specs branch June 26, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: connect stores tsnet state in a CWD-relative ./ts-state — leaks node identity into the working dir (and any auto-committed repo)

1 participant

@mlorentedev