Repository navigation
fix: use loopback flight location by default - #427
Merged
TomKaltofen merged 1 commit intoMay 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.0.0.0to127.0.0.1create_location()hostOn Windows,
tests/test_core/test_flight/test_flight_server.py::TestFlightServerIntegration::test_server_operationsfailed before this change because the client tried to connect togrpc://0.0.0.0:<port>, which producedWSA Error 10049.0.0.0.0is useful as a bind-all address, but it is not a portable client target.This follows #426 and intentionally leaves the SQLite temp-file lock class from #424 separate.
Tests
.venv\Scripts\python.exe -m pytest tests\test_core\test_flight\test_flight_server.py -q.venv\Scripts\python.exe -m pytest tests\test_core\test_artifacts\test_artifacts.py::TestBaseArtifacts::test_basic_artifact_feature -q.venv\Scripts\python.exe -m pytest tests\test_plugins\compute_framework\base_implementations\sqlite -q.venv\Scripts\ruff.exe format --check mloda\core\runtime\flight\flight_server.py tests\test_core\test_flight\test_flight_server.py.venv\Scripts\ruff.exe check mloda\core\runtime\flight\flight_server.py tests\test_core\test_flight\test_flight_server.pyPart of #424.