Skip to content

fix: use loopback flight location by default - #427

Merged
TomKaltofen merged 1 commit into
mloda-ai:mainfrom
snoopuppy582:fix/windows-flight-loopback
May 17, 2026
Merged

TomKaltofen merged 1 commit into
mloda-ai:mainfrom
snoopuppy582:fix/windows-flight-loopback

Conversation

@snoopuppy582

Copy link
Copy Markdown
Contributor

Summary

On Windows, tests/test_core/test_flight/test_flight_server.py::TestFlightServerIntegration::test_server_operations failed before this change because the client tried to connect to grpc://0.0.0.0:<port>, which produced WSA Error 10049. 0.0.0.0 is useful as a bind-all address, but it is not a portable client target.

This follows #426 and intentionally leaves the SQLite temp-file lock class from #424 separate.

Tests

  • .venv\Scripts\python.exe -m pytest tests\test_core\test_flight\test_flight_server.py -q
  • .venv\Scripts\python.exe -m pytest tests\test_core\test_artifacts\test_artifacts.py::TestBaseArtifacts::test_basic_artifact_feature -q
  • .venv\Scripts\python.exe -m pytest tests\test_plugins\compute_framework\base_implementations\sqlite -q
  • .venv\Scripts\ruff.exe format --check mloda\core\runtime\flight\flight_server.py tests\test_core\test_flight\test_flight_server.py
  • .venv\Scripts\ruff.exe check mloda\core\runtime\flight\flight_server.py tests\test_core\test_flight\test_flight_server.py

Part of #424.

@snoopuppy582
snoopuppy582 requested a review from TomKaltofen as a code owner May 16, 2026 22:31
@TomKaltofen
TomKaltofen merged commit 5104592 into mloda-ai:main May 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants