Skip to content

fix: remove stale bandit suppression code - #423

Merged
TomKaltofen merged 1 commit into
mloda-ai:mainfrom
snoopuppy582:fix/remove-stale-bandit-nosec-422
May 14, 2026
Merged

TomKaltofen merged 1 commit into
mloda-ai:mainfrom
snoopuppy582:fix/remove-stale-bandit-nosec-422

Conversation

@snoopuppy582

Copy link
Copy Markdown
Contributor

Summary

  • Replace the stale # nosec B608 marker with a generic # nosec on the SQLite mask engine test SQL expression.
  • This keeps the intentional Bandit suppression while removing the CI warning reported in warning in CI #422.

Related Issue

Tests

  • uv run bandit -c pyproject.toml -r -q .
  • uv run pytest tests/test_plugins/compute_framework/base_implementations/sqlite/test_sqlite_mask_engine.py -q
  • uv run ruff check tests/test_plugins/compute_framework/base_implementations/sqlite/test_sqlite_mask_engine.py
  • uv run ruff format --check tests/test_plugins/compute_framework/base_implementations/sqlite/test_sqlite_mask_engine.py

Notes

  • I also attempted full tox locally on Windows with Git sh.exe on PATH. It reached the pytest phase and failed on existing Windows-local issues unrelated to this one-line Bandit change: CP949 markdown decode errors, SQLite temp-file lock teardown errors, and PyArrow Flight 0.0.0.0 connection errors.

@snoopuppy582
snoopuppy582 requested a review from TomKaltofen as a code owner May 13, 2026 18:40
@TomKaltofen
TomKaltofen merged commit ec2c319 into mloda-ai:main May 14, 2026
15 checks passed
@TomKaltofen

Copy link
Copy Markdown
Contributor

@snoopuppy582 Thank you for the PR and mentioning the local windows issue. I have no windows PC, so this is a really helpful message. Any github start is also appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

warning in CI

2 participants