Skip to content

Replace TokenType.keyword with TokenType.Keyword (capital K)#6901

Merged
harupy merged 1 commit intomlflow:masterfrom
harupy:replace-keyword-with-Keyword
Sep 27, 2022
Merged

Replace TokenType.keyword with TokenType.Keyword (capital K)#6901
harupy merged 1 commit intomlflow:masterfrom
harupy:replace-keyword-with-Keyword

Conversation

@harupy
Copy link
Copy Markdown
Member

@harupy harupy commented Sep 27, 2022

Signed-off-by: harupy [email protected]

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

A follow-up PR for #6884. Replaces TokenType.keyword with TokenType.Keyword.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.
> pip install sqlparse==0.4.2
> pytest tests/store/model_registry/test_sqlalchemy_store.py -k test_parse_search_registered_models_order_by
                                                                                                                                                                                                                                                                                               
...

tests/store/model_registry/test_sqlalchemy_store.py::TestSqlAlchemyStoreSqlite::test_parse_search_registered_models_order_by PASSED                                                                                                                                                                                                       [100%]

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Click the Details link on the Preview docs check.
  2. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/pipelines: Pipelines, Pipeline APIs, Pipeline configs, Pipeline Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: harupy <[email protected]>
@harupy harupy marked this pull request as ready for review September 27, 2022 05:44
@harupy harupy changed the title Replace TokenType.keyword with TokenType.Keyword (k -> K) Replace TokenType.keyword with TokenType.Keyword Sep 27, 2022
@harupy harupy changed the title Replace TokenType.keyword with TokenType.Keyword Replace TokenType.keyword with TokenType.Keyword (capital K) Sep 27, 2022
@harupy harupy requested a review from WeichenXu123 September 27, 2022 05:53
@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Sep 27, 2022
Copy link
Copy Markdown
Member

@BenWilson2 BenWilson2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harupy harupy merged commit 3d6827f into mlflow:master Sep 27, 2022
@harupy harupy deleted the replace-keyword-with-Keyword branch September 27, 2022 22:49
@harupy harupy mentioned this pull request Sep 28, 2022
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants