Skip to content

Discourage use of conda and recommend virtualenv#6507

Merged
harupy merged 8 commits intomlflow:branch-2.0from
harupy:warn-conda
Aug 23, 2022
Merged

Discourage use of conda and recommend virtualenv#6507
harupy merged 8 commits intomlflow:branch-2.0from
harupy:warn-conda

Conversation

@harupy
Copy link
Copy Markdown
Member

@harupy harupy commented Aug 18, 2022

Signed-off-by: harupy [email protected]

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Discourage use of conda and recommend virtualenv.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Click the Details link on the Preview docs check.
  2. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/pipelines: Pipelines, Pipeline APIs, Pipeline configs, Pipeline Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@github-actions github-actions bot added area/models MLmodel format, model serialization/deserialization, flavors area/projects MLproject format, project running backends rn/none List under Small Changes in Changelogs. labels Aug 18, 2022

.. _project-conda-environments:

Conda environment (discouraged)
Copy link
Copy Markdown
Collaborator

@dbczumar dbczumar Aug 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Conda environment (discouraged)
Conda environment

Below, can we also tell users that, by using conda, the user is responsible for adhering to Anaconda's terms of service?

Copy link
Copy Markdown
Member Author

@harupy harupy Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed (discouraged) and added a warning for Anaconda's TOS.

Copy link
Copy Markdown
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harupy Awesome stuff! LGTM with a few comments!

Copy link
Copy Markdown
Collaborator

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @dbczumar 's comments being addressed.

harupy added 3 commits August 22, 2022 13:17
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
@harupy harupy requested a review from dbczumar August 22, 2022 07:15
Copy link
Copy Markdown
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @harupy !

harupy added 3 commits August 23, 2022 10:47
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
@harupy harupy merged commit c183f36 into mlflow:branch-2.0 Aug 23, 2022
@harupy harupy deleted the warn-conda branch August 23, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/models MLmodel format, model serialization/deserialization, flavors area/projects MLproject format, project running backends rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants