Skip to content

Fix normalize_mcp_server_version_filter_string for quoted literals - #26432

Closed
Subodh-17 wants to merge 1 commit into
mlflow:masterfrom
Subodh-17:fix/mcp-version-filter-quoted-literals-v2
Closed

Subodh-17 wants to merge 1 commit into
mlflow:masterfrom
Subodh-17:fix/mcp-version-filter-quoted-literals-v2

Conversation

@Subodh-17

Copy link
Copy Markdown

Related Issues/PRs

Closes #26387

What changes are proposed in this pull request?

Fix MCP server version filter normalization so that occurrences of versionLIKE and versionILIKE inside quoted string literals are not incorrectly rewritten as the version identifier.

The fix moves the normalization to the token level in SearchMCPServerVersionUtils, following the existing token-level handling used by SearchMCPAccessEndpointUtils. Quoted string literals are therefore left unchanged while the bare version identifier retains its existing normalization behavior.

Regression coverage verifies single- and double-quoted literals, affected versionLIKE/versionILIKE values, filter ordering, comparison operators, and both workspace modes.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Does this PR require updating the MLflow Skills repository?

  • No.
  • Yes. Please link the corresponding PR or explain how you plan to update it.

Release Notes

Is this a user-facing change?

  • No.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Fixes MCP server version searches when quoted server-name filter values contain versionLIKE or versionILIKE; quoted literals are no longer rewritten during version-filter normalization.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Is this PR a critical bugfix or security fix that should go into the next patch release?

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0). Minor releases are expected to contain larger changes, such as new features and improvements. Non-critical bug fixes and doc updates can be included as well. By default, your PR should target the next minor release.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1). Patch releases are typically only performed when there has been a major regression or bug in the latest release. For the sake of stability, your PR should not be included in a patch release unless it is a critical fix, or if the risk level of your PR is exceedingly low.
  • This PR is critical and needs to be in the next patch release
  • This PR can wait for the next minor release

@github-actions github-actions Bot added community Community/external contribution area/tracking Tracking service, tracking client APIs, autologging rn/bug-fix Mention under Bug Fixes in Changelogs. labels Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor
Install mlflow from this PR

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/26432/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/26432/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/26432/merge

PR author's recent activity

In the last 14 days, @Subodh-17 opened 17 PRs across 10 repos:

Repository Open Closed Merged Total
mlflow/mlflow 1 3 0 4
knight22-21/CodePrism 0 1 2 3
huggingface/transformers 2 0 0 2
mloda-ai/mloda 0 2 0 2
Lightning-AI/pytorch-lightning 1 0 0 1
safetensors/safetensors 1 0 0 1
modelscope/ms-swift 1 0 0 1
aeshef/obsidian-agent 1 0 0 1
batrapulkit/squidbrake 0 0 1 1
airbytehq/airbyte 1 0 0 1

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

This PR was automatically closed because #26387 is assigned to @Amazinghorseli, @aaronteo-db. If you believe this was done in error, please reach out to a maintainer. Please do not force-push to or delete the PR branch so this PR can be reopened.

@github-actions github-actions Bot closed this Oct 5, 2026
@github-actions github-actions Bot added the size/M label Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tracking Tracking service, tracking client APIs, autologging community Community/external contribution rn/bug-fix Mention under Bug Fixes in Changelogs. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] MCP server version search rewrites quoted name filter values containing versionLIKE/versionILIKE

1 participant