Repository navigation
fix: keep equity calendar helpers on authoritative schedules - #92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91.
EquityCalendar now uses the existing authoritative schedule adapter for membership and duration instead of a weekday fallback. Closed sessions have zero duration; breaks and interruptions are excluded. Boundary lookup and session enumeration consistently normalize naive timestamps in the configured timezone, defaulting to the selected exchange timezone. Lookup without an authoritative boundary fails clearly.
The canonical calendar selector retains the legacy exchange/positional alias and rejects conflicting values. Session annotations use authoritative labels, including overnight sessions, rather than timestamp civil dates. Duration consumes the session-label date and does not substitute the next session's overnight opening date. An EquityCalendar object requires a named schedule. Calendar-free consumers remain separate. The existing feature guide and calendar instructions describe the compatibility changes for the next minor version, not the separate 0.1.7 release/archive work.
Regression evidence
Limits
This does not complete all calendar/time harmonization. Shared FeedSpec adoption in calendar-aware labeling, row/session/elapsed horizon semantics and legacy CryptoCalendar helper semantics remain separately assessed work. No release/tag/deployment is requested. The immutable Specs source dependency and publication guard remain unchanged.
AI assistance: Codex reproduced failures through public APIs and the installed base wheel, implemented source/tests/docs changes, reviewed the diff and ran the listed checks. No unexecuted full-suite or hosted result is claimed.