Repository navigation
fix(calendar)!: use UTC daily crypto sessions and maintenance - #103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #100.
Use the existing authoritative PandasMarketCalendar 24/7 adapter for CryptoCalendar. Enumerate one daily UTC session open rather than treating every hour as a session. Normalize membership and annotations to UTC, subtract explicit half-open maintenance windows including overnight windows, and return strict adjacent session boundaries rather than arbitrary immediate instants or intraday maintenance reopens. Canonical calendar='24/7' and the existing CRYPTO_24_7 alias select the continuous schedule; None belongs to calendar-free consumers and is rejected on a concrete schedule object.
This intentionally changes legacy helper outputs on the next-minor 0.2 development line. It is not part of the historical 0.1.7 patch. Existing maintenance constructor arguments/name remain; invalid windows fail before constructing a misleading schedule. The calendars extra is now required rather than silently manufacturing a schedule. The existing feature guide explains units, boundary/maintenance/timezone changes and row-mode migration. No new wire format or annualization rule.
Evidence at f61ae28, tree ac9e5f0be5888692d5591ffa0e05d63d08d2a677:
Current-head supported hosted gates remain required before ordinary merge. This branch still honestly uses the existing immutable Specs qualification dependency; published dependency adoption is independently qualified in PR102. Remaining daily feature grids and session/elapsed consumers are not claimed complete by this helper repair. No release/tag/docs deployment.
AI assistance: Codex reproduced the actual source/installed workflows, implemented and reviewed the focused repair and migration text, and executed the listed checks. No independent human review is claimed.