Skip to content

Commit b6ad633

Browse files
cursoragentquantum-like
authored andcommitted
fix(features): match Roll spread warm-up to the corrected covariance
The registered warm-up was twice the window because the old estimator nested two rolling means. The window covariance is first defined one bar after the lag is available. Co-authored-by: quantum-like <[email protected]>
1 parent 79cded1 commit b6ad633

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎src/ml4t/engineer/core/lookbacks.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ def _ulcer_index(params: Mapping[str, Any]) -> int:
153153
"price_impact_ratio": _parameter("period", -1),
154154
"quote_stuffing_indicator": _scaled_parameter("period", 4, -1),
155155
"realized_spread": _parameter("period", -1),
156-
"roll_spread_estimator": _scaled_parameter("period", 2),
156+
"roll_spread_estimator": _parameter("period", 1),
157157
"trade_intensity": _parameter("period", -1),
158158
"volume_at_price_ratio": _parameter("period", -1),
159159
"volume_synchronicity": _scaled_parameter("period", 2, -1),

0 commit comments

Comments
 (0)