Repository navigation
feat(adjustments): prepare versioned action facts and explicit factors - #126
Merged
Merged
Conversation
added 9 commits
October 20, 2026 16:53
…offs Retain timestamp precision, declared label clocks and source keys. Keep sparse price panels reversible without filling observations or rounding integer prices. Exercise actual disk, calendar and recovery workflows plus an offline migration recipe. Refs #117
Record the installed wheel/sdist consumer versions and the incompatible published Engineer boundary. Add a regression that retains a wholly null input session instead of compressing its clock. Closes #117
…tinctions Reproduce naive New York instants shifted to UTC incorrectly and preserve them through bounded disk reads. Keep source NaN distinct from null across price panels and retain pandas label timezones. Validate bad timezone metadata before replacing source generations. Refs #117
Keep axis identity and native schema metadata serializable without Arrow as a runtime requirement. Exercise an actual pandas Parquet round trip retaining absent observations, nulls and source dtypes. Document the native panel APIs and remove unqualified storage timing claims. Refs #117
Retain source terms, availability and unknown coverage without broker effects. Keep imported factor definitions explicit and reuse shared feed declarations. Refs #118.
…tor provenance Add an offline CSV-to-disk workflow, explicit unknown-term coverage and destination-ID validation. Reject reserved factor output fields rather than silently overwrite their source method. Public workflow regression fails on e58be69 and passes after repair. Seven producer controls cover accepted premises. Closes #118.
added 2 commits
October 20, 2026 19:21
Resolve squash-ancestry-only conflicts by retaining the existing qualified action code and guide. Main has the exact bfc source tree; the resolved merge tree is byte-identical to existing3947654. Preserve both histories and require fresh main-head hosted checks.
Actual finite CSV terms can overflow under reciprocal or rational normalization,or underflow to zero. Validate the canonical ratio after normalization before publishing event facts. Three public-input regressions fail on5a4b and pass with the guard;134 focused adjustment/handoff ResourceWarning-clean tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow
Prepare versioned corporate-action facts and imported price/volume factors without changing native financial definitions or adding broker accounting.
Closes #118. Prerequisites #123 and #125 are merged. This PR targets main and incorporates it through a normal merge preserving both histories.
Implementation
prepare_action_inputsretains stable IDs, event/revision/source identity, raw terms and announced/available/effective/ex/entitlement/payment dates. Imported split conventions are explicit; rational terms must agree. Captured instrument membership validates source and destination IDs. Unknown applicable terms remain null with coverage, not invented consideration.apply_adjustment_factorspreserves raw observations and supplied definitions. Exact unique key coverage, positive finite factors, currency compatibility and reserved output fields are validated before output. Volume adjusts only when supplied. No orders, positions, entitlement or payment effects.Executed qualification
79dd1e9f78b577027807824dbc1b9aa49e49dd3fadditionally rejects overflow/underflow after split-ratio normalization. Three actual CSV-input regressions fail on5a4b2baand pass with the repair; 134 focused adjustment/handoff ResourceWarning tests, lint, format, ty and hooks pass. All seven premise/claim correct/failing-producer controls pass again on the repaired source, without waivers or deferrals.0.2.2.dev28+g79dd1e9f7; all167 packaged source files match that Git revision. Both isolated installs also reject the three invalid derived-ratio cases through the actual public API.c69e7badaac012ad98b1c4b8aa9a67a952b08f5c, Diagnostic0.1.9, pandas3.0.6 and Polars2.0.0. This is source-candidate integration, not a claim that the currently released Engineer resolves with Specs0.2.No causal as-of guarantee is claimed by this preparation API. No analytical cleaner, runtime history engine, broker, mandatory Reloaded dependency, release, tag, publication or documentation deployment.
AI assistance was used for implementation, tests and documentation. The producing workflow, substantive diff, independent financial oracles and failure controls were reviewed in the Data owner workflow.