Repository navigation
fix: preserve missing market observations instead of imputing prices - #114
Merged
stefan-jansen merged 2 commits intoOct 18, 2026
Merged
Conversation
stefan-jansen
merged commit Oct 18, 2026
60f6591
into
fix/stored-calendar-gap-report
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #109 under the maintainer's revised requirement: preserve missing market observations and remove synthetic imputation, not improve a filler.
Outcome and compatibility
API/CLI/config/bulk updates use independent check_gaps controls. No automatic synthetic rows, copied prices, interpolated values or invented zero volume. Explicit legacy fill_gaps=True/--fill-gaps requests fail before acquisition or dataset creation; False remains a safe compatibility alias for disabling checks. Source history limits no longer suppress detection. Metadata distinguishes disabled checks from zero reported gaps and never claims synthetic rows were recovered.
The general fill_gaps helper rejects nonempty requests. The existing optional native minute-grid view retains absent positions as null placeholders; it rejects price-filling methods and zero_volume=True. The legacy is_imputed marker is preserved. Existing observations, including null prices, remain unchanged. DataManager.complete_sessions(fill_gaps=False) still assigns sessions without expansion.
Update existing guides/config/examples to remove synthetic-filling recommendations. Preserve the old session documentation anchor and use the shared data-root helper instead of a private example path. No new Markdown page.
Executed evidence
Review and prerequisites
Owner reviewed the actual source/tests/docs diff and intentional compatibility change. AI-assisted implementation and qualification under maintainer direction; no independent reviewer claimed. Deprecated synthetic-filling enhancement d1531a9 is superseded and must not merge.
Stacked draft after report PR113, which is itself after published-Specs PR112. Integrate only the next selected dependent revision, retarget to main and require every applicable exact-head CI/platform/package/resource/security/docs gate before ordinary merge. Draft/stacked trigger exclusions are not qualification. Issue110's remaining bounded-frame/placeholder reporting and targeted source acquisition are not claimed complete by this change. Data0.2.1 unchanged; no release/deploy.