Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ml4t/data
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.1.4
Choose a base ref
...
head repository: ml4t/data
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.1.5
Choose a head ref
  • 1 commit
  • 2 files changed
  • 2 contributors

Commits on Sep 8, 2026

  1. Name the day and the reason when an async Binance download fails (#48) 

    The async daily path returned a bare exception and logged `f"Failed to download:
{result}"`. `str(exc)` is empty for an exception raised with no arguments, so the
line rendered with no subject and no reason at all. Run 33988501549 of the book
repository's reader-install job emitted 569 of them, which is what turned a
five-symbol Binance outage into a whole seven-dataset job failing with nothing to
read. The premium-index monthly path had the same shape at debug level.

`fetch_one` now carries the date out with the failure, and both sites log
structured fields through `_failure_reason`, which falls back to the exception's
type when it carries no message:

  Failed to download  date=2024-01-02 reason=TimeoutError symbol=BTCUSDT

Four tests, including one that drives the async daily path with an argument-less
`TimeoutError` and asserts the old subject-less line is not what comes out.

`uv run pytest tests/ -q`: 3,623 passed, 280 deselected. ruff and ty clean.

Co-authored-by: Stefan Jansen <[email protected]>
    @stefan-jansen Stefan Jansen
    stefan-jansen and Stefan Jansen authored Sep 8, 2026
    Configuration menu
    Copy the full SHA
    a5cade3 View commit details
    Browse the repository at this point in the history
Loading