@@ -190,7 +190,7 @@ def _daily_ranges(
190190 assigner = SessionAssigner (calendar )
191191 observed = {
192192 value .date () if isinstance (value , datetime ) else value
193- for value in df ["timestamp" ].to_list ()
193+ for value in ObservationGapDetector . _observed_rows ( df ) ["timestamp" ].to_list ()
194194 }
195195 schedule = assigner .calendar .schedule (start_date = start .date (), end_date = end .date ())
196196 gaps = []
@@ -226,6 +226,8 @@ def detect_gaps(
226226 calendar : str | None | CalendarUnset = UNSET_CALENDAR ,
227227 feed_spec : Any | None = None ,
228228 tolerance_bars : int = 0 ,
229+ start_date : datetime | None = None ,
230+ end_date : datetime | None = None ,
229231 ) -> list [dict [str , Any ]]:
230232 """
231233 Detect gaps in a DataFrame's timestamp column.
@@ -237,24 +239,44 @@ def detect_gaps(
237239 calendar: Per-call override of configured calendar and feed metadata.
238240 feed_spec: Per-call feed declaration.
239241 tolerance_bars: Number of consecutive missing intraday bars to tolerate.
242+ start_date: Inclusive requested coverage start; supply together with end_date.
243+ end_date: Inclusive coverage end. Daily bounds are labels; intraday bounds are instants.
240244
241245 Returns:
242246 List of gap dictionaries with start, end, and size
243247 """
248+ if (start_date is None ) != (end_date is None ):
249+ raise ValueError ("start_date and end_date must be supplied together" )
244250 feed , selected = self ._feed_calendar (calendar , feed_spec )
245251 frequency = (feed .data_frequency or "daily" ) if frequency is None else frequency
246252 if selected is None :
247253 return []
248- if df .is_empty () or "timestamp" not in df . columns :
254+ if df .is_empty () and start_date is None :
249255 return []
256+ if feed .timestamp_col != "timestamp" :
257+ if feed .timestamp_col not in df .columns :
258+ raise ValueError (f"declared timestamp column { feed .timestamp_col !r} is missing" )
259+ df = df .select (
260+ pl .col (feed .timestamp_col ).alias ("timestamp" ),
261+ * [name for name in df .columns if name not in {"timestamp" , feed .timestamp_col }],
262+ )
263+ feed = feed .with_overrides (timestamp_col = "timestamp" )
264+ if "timestamp" not in df .columns :
265+ if not df .is_empty ():
266+ raise ValueError ("DataFrame must have 'timestamp' column" )
267+ df = df .with_columns (pl .Series ("timestamp" , [], dtype = pl .Datetime ("us" , "UTC" )))
250268 if frequency .lower () in {"daily" , "1day" , "1d" }:
251269
252270 def daily_ranges (part : pl .DataFrame ) -> list [dict [str , Any ]]:
253271 labeled = self ._label_frame (part , feed , selected )
254272 return self ._daily_ranges (
255273 labeled ,
256- _session_label (labeled ["timestamp" ].min ()),
257- _session_label (labeled ["timestamp" ].max ()),
274+ _session_label (
275+ start_date if start_date is not None else labeled ["timestamp" ].min ()
276+ ),
277+ _session_label (
278+ end_date if end_date is not None else labeled ["timestamp" ].max ()
279+ ),
258280 selected ,
259281 tolerance_days ,
260282 )
@@ -267,7 +289,13 @@ def daily_ranges(part: pl.DataFrame) -> list[dict[str, Any]]:
267289 df ,
268290 feed ,
269291 lambda part : self ._intraday_ranges (
270- part , frequency , selected , feed , tolerance_bars = tolerance_bars
292+ part ,
293+ frequency ,
294+ selected ,
295+ feed ,
296+ tolerance_bars = tolerance_bars ,
297+ start = _ensure_datetime (start_date ) if start_date is not None else None ,
298+ end = _ensure_datetime (end_date ) if end_date is not None else None ,
271299 ),
272300 )
273301 if (
@@ -329,8 +357,8 @@ def _intraday_ranges(
329357 if grid is None :
330358 return []
331359 positions = sorted ({grid .position (timestamp ) for timestamp in observed })
332- first = grid .bound (start ) if start is not None else positions [ 0 ]
333- stop = grid .bound (end , inclusive = True ) if end is not None else positions [ - 1 ] + 1
360+ first = grid .bound (grid . start )
361+ stop = grid .bound (grid . end , inclusive = True )
334362 gaps = []
335363 cursor = first
336364 for position in [p for p in positions if first <= p < stop ] + [stop ]:
0 commit comments