Skip to content

Commit 1501f00

Browse files
fix: do not infer crypto weekends from intraday row counts
Closes #105. Remove the row-count/weekend-presence heuristic while preserving chronological gap detection. Actual provider regressions cover direct and AssetValidator callers, genuine weekend outages and complete short windows. Owner reviewed base failures, passing fix and compatibility; all applicable exact-head gates passed. AI-assisted maintenance under maintainer direction.
1 parent 2edaed3 commit 1501f00

2 files changed

Lines changed: 35 additions & 12 deletions

File tree

‎src/ml4t/data/calendar/crypto.py‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -316,17 +316,6 @@ def validate_continuity(
316316
f"({duration.total_seconds() / 3600:.1f} hours)"
317317
)
318318

319-
# Check for weekend data (crypto should have it)
320-
timestamps = df["timestamp"].to_list()
321-
weekend_dates = [
322-
ts
323-
for ts in timestamps
324-
if ts.weekday() in [5, 6] # Saturday, Sunday
325-
]
326-
327-
if not weekend_dates and len(timestamps) >= 7:
328-
issues.append("Missing weekend data (crypto trades 24/7)")
329-
330319
return issues
331320

332321
def validate_volume_profile(

‎tests/test_crypto_assets.py‎

Lines changed: 35 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,48 @@
33
from datetime import UTC, datetime, timedelta
44

55
import polars as pl
6+
import pytest
67

78
from ml4t.data.assets import AssetClass, AssetInfo, AssetSchema, AssetValidator
89
from ml4t.data.assets.asset_class import (
910
get_asset_class_from_symbol,
1011
normalize_crypto_symbol,
1112
parse_crypto_symbol,
1213
)
13-
from ml4t.data.calendar.crypto import CryptoCalendar
14+
from ml4t.data.calendar.crypto import CryptoCalendar, CryptoSessionValidator
15+
from ml4t.data.providers import SyntheticProvider
16+
17+
18+
@pytest.fixture(params=["direct", "asset"])
19+
def continuity_issues(request):
20+
def validate(frame, frequency):
21+
if request.param == "direct":
22+
return CryptoSessionValidator().validate_continuity(frame, frequency)
23+
info = AssetInfo(symbol="BTC/USD", asset_class=AssetClass.CRYPTO)
24+
return AssetValidator(info).validate(frame, frequency).get("continuity", [])
25+
26+
return validate
27+
28+
29+
@pytest.mark.parametrize("frequency", ["minute", "hourly"])
30+
def test_seven_monday_bars_do_not_imply_a_missing_weekend(continuity_issues, frequency):
31+
with SyntheticProvider(calendar_mode="continuous") as provider:
32+
frame = provider.fetch_ohlcv("BTCUSD", "2025-07-07", "2025-07-07", frequency).head(7)
33+
assert continuity_issues(frame, frequency) == []
34+
35+
36+
def test_real_missing_crypto_weekend_remains_a_continuity_gap(continuity_issues):
37+
with SyntheticProvider(calendar_mode="continuous") as provider:
38+
frame = provider.fetch_ohlcv("BTCUSD", "2025-07-07", "2025-07-15", "daily")
39+
frame = frame.filter(pl.col("timestamp").dt.weekday() <= 5)
40+
issues = continuity_issues(frame, "daily")
41+
assert any("Gap detected: 2025-07-11" in issue and "72.0 hours" in issue for issue in issues)
42+
43+
44+
def test_complete_crypto_week_has_no_continuity_gap(continuity_issues):
45+
with SyntheticProvider(calendar_mode="continuous") as provider:
46+
frame = provider.fetch_ohlcv("BTCUSD", "2025-07-07", "2025-07-13", "daily")
47+
assert continuity_issues(frame, "daily") == []
1448

1549

1650
class TestCryptoCalendar:

0 commit comments

Comments
 (0)