Repository navigation
Align example projects with the Python 3.10 minimum - #4024
Merged
Merged
Conversation
zcbenz
approved these changes
Aug 6, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
MLX has required Python 3.10 since #2694, but the two example projects still carry the older floors:
examples/cmake_project/CMakeLists.txtasks forPython 3.9examples/extensions/setup.pydeclarespython_requires=">=3.8"For reference, the rest of the tree agrees on 3.10:
setup.pyusespython_requires=">=3.10", the top levelCMakeLists.txtlooks forPython 3.10, andinstall.rststates it in three places.It is only cosmetic on a supported interpreter, but on 3.8 or 3.9 the example projects currently accept the environment and then fail later when MLX turns out not to be installable, rather than saying up front that the interpreter is too old.
Checked that the cmake example still configures, builds and prints the output its README promises:
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes(two one word changes; verified by building and running the cmake example before and after)
process note as usual: freshman contributor, Claude Code helps me look around, but i traced this by grepping every Python version reference in the tree, found the bump commit that moved the project to 3.10, and confirmed these two were simply left behind rather than intentionally lower. i also rebuilt the example to be sure raising the floor did not break it.