Repository navigation
Fix broken all_sum and Group references in the data parallelism example - #3996
Merged
zcbenz merged 1 commit intoAug 5, 2026
Merged
Conversation
zcbenz
approved these changes
Aug 5, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The data parallelism example links to
all_sumandGroupwith bare names, but that page has nocurrentmoduledirective, so neither resolves and both render as plain text instead of links:Both live under
mlx.core.distributed, and the sibling pagetensor_parallelism.rstalready writes them fully qualified, so this brings the two pages in line. The other two references on the page were already fully qualified (mlx.nn.average_gradients,mlx.utils.tree_map), so these two were the odd ones out.After the change the page builds with no unresolved references.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes(docs only; verified by building the docs with
-nbefore and after)usual note on process: freshman contributor, i lean on Claude Code for the sweeping, but i built the docs in nitpick mode myself, read the warnings, and checked how the neighbouring tensor parallelism page writes the same two references before picking the fix.