Repository navigation
Document default values in normalization layer docstrings - #3819
Merged
Merged
Conversation
LayerNorm, RMSNorm and GroupNorm did not list the default values for eps/affine/bias in their docstrings, unlike BatchNorm and InstanceNorm in the same module. Add the missing Default annotations so they match the signatures and the surrounding convention.
3 of 4 tasks
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LayerNorm,RMSNormandGroupNormdocstrings listeps,affineandbiaswithout their default values, unlikeBatchNormandInstanceNormin the same module which do.This adds the missing
Default:annotations so the docstrings match the constructor signatures and the surrounding convention:LayerNorm:eps=1e-5,affine=True,bias=TrueRMSNorm:eps=1e-5GroupNorm:eps=1e-5,affine=True,pytorch_compatible=FalseDocs only, no behavior change.